libvncserver: handle EINTR #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk138
reviewed
Apr 10, 2022
| n = select(nfds + 1, &rfds, &wfds, &efds, &tv); | ||
|
|
||
| if (n < 0) { | ||
| rfbLogPerror("ReadExact: select"); | ||
| if (errno == EINTR) { | ||
| goto retry; |
There was a problem hiding this comment.
why wouldn't a simple continue work as in the other cases?
There was a problem hiding this comment.
@piec the goto itself is not an issue, the problem is if the client disconnect.
In that case the FD will become invalid, but your retry will cut the check done some line before, and it will never finish till it'll probably crash.
So please try with the continue, I cannot reproduce the problem to test.
|
I don't remember if I've tried it, I'll have to check again |
That'd be nice - thank's in advance! |
|
Needs a check if |
|
I'll get some time to look at it at the beginning of next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using libvncserver in a program that uses many signals, I have no control over that.
I noticed that this select sometimes gets an EINTR.
The proposed fix is not pretty because it uses a goto but it's also simple & readable.
Please tell me if you'd prefer a
do {} whileloop. The disadvantage is that thebreakafter would have to changed.Thanks for this awesome lib
Pierre
PS: I suspect other syscalls could have issues too